[TASK] Migrate controller tests to functional tests (deleteAction)#1734
Merged
oliverklee merged 1 commit intomainfrom Jul 7, 2025
Merged
Conversation
DanielSiepmann
force-pushed
the
1569-migrate-existing-unit-tests-to-functional-split-delete-action
branch
from
89ff4fe to
f2bda2a
Compare
Pull Request Test Coverage Report for Build 16116811570Details
💛 - Coveralls |
DanielSiepmann
force-pushed
the
1569-migrate-existing-unit-tests-to-functional-split-delete-action
branch
from
f2bda2a to
54ce26e
Compare
oliverklee
requested changes
Jul 7, 2025
DanielSiepmann
force-pushed
the
1569-migrate-existing-unit-tests-to-functional-split-delete-action
branch
from
54ce26e to
6f0af6e
Compare
oliverklee
reviewed
Jul 7, 2025
| private const PAGE_UID = 1; | ||
| private const TEA_UID_OWNED_BY_LOGGED_IN_USER = '1'; | ||
| private const TEA_UID_OWNED_BY_FOREIGN_USER = '2'; | ||
| private const TEA_UID_WITHOUT_OWNER = '3'; |
Contributor
There was a problem hiding this comment.
I've thought about this some more … The updated naming still has the issue that the "owned" gramatically refers to the UID, not the tea. I've now come up with this:
private const UID_OF_TEA_OWNED_BY_LOGGED_IN_USER = '1';
private const UID_OF_TEA_OWNED_BY_FOREIGN_USER = '2';
private const UID_OF_TEA_WITHOUT_OWNER = '3';
Contributor
Author
There was a problem hiding this comment.
Adjusted. I also adjusted PAGE_UID to consistency.
It is considered best practice to cover controllers via functional instead of unit tests. We therefore migrate the existing unit tests to functional tests. The migration is split into multiple batches for smaller changes. This one covers tests related to `deleteAction()`. Relates: #1569
DanielSiepmann
force-pushed
the
1569-migrate-existing-unit-tests-to-functional-split-delete-action
branch
from
6f0af6e to
5458427
Compare
oliverklee
approved these changes
Jul 7, 2025
oliverklee
deleted the
1569-migrate-existing-unit-tests-to-functional-split-delete-action
branch
github-project-automation
Bot
moved this from In review
to Done
in Best Practices code sprint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is considered best practice to cover controllers via functional instead of unit tests.
We therefore migrate the existing unit tests to functional tests.
The migration is split into multiple batches for smaller changes. This one covers tests related to
deleteAction().Relates: #1569