[TASK] Move phpCsFixer to a bash function#2113
Merged
oliverklee merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
Coverage Report for CI Build 25319960395Coverage remained the same at 96.678%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
oliverklee
changed the title
phpCsFixer into a Bash commandphpCsFixer into a bash function
oliverklee
changed the title
phpCsFixer into a bash functionphpCsFixer to a bash function
oliverklee
approved these changes
May 4, 2026
Contributor
oliverklee
left a comment
oliverklee
left a comment
There was a problem hiding this comment.
This works fine:
- detect and show issues with
./Build/Scripts/runTests.sh -s phpCsFixer -- --dry-run - exit code != 0 if there are issues
- exit code = 0 if there are no issues
This doesn't work on my machine (but also was broken before):
- actually fix the code using
./Build/Scripts/runTests.sh -s phpCsFixer
I'll add a ticket for that.
github-project-automation
Bot
moved this from In Review
to Done
in Best Practices code sprint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.