Skip to content

[BUGFIX] Actually fix the code with runTests.sh -s phpCsFixer#2136

Merged
kanow merged 1 commit into
mainfrom
bugfix/fixer-fix
May 22, 2026
Merged

[BUGFIX] Actually fix the code with runTests.sh -s phpCsFixer#2136
kanow merged 1 commit into
mainfrom
bugfix/fixer-fix

Conversation

@oliverklee
Copy link
Copy Markdown
Contributor

Also align the dry-run handling with what the Core runTests.sh now does.

Fixes #2120

Also align the dry-run handling with what the Core `runTests.sh`
now does.

Fixes #2120
@oliverklee oliverklee added this to the 4.1.0 milestone May 21, 2026
@oliverklee oliverklee self-assigned this May 21, 2026
@oliverklee oliverklee added bug Something isn't working runTests.sh labels May 21, 2026
@oliverklee oliverklee requested a review from a team May 21, 2026 17:55
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26243608195

Warning

No base build found for commit d2bf2f6 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 96.678%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 301
Covered Lines: 291
Line Coverage: 96.68%
Coverage Strength: 3.98 hits per line

💛 - Coveralls

@oliverklee oliverklee requested a review from sbuerk May 21, 2026 18:05
Copy link
Copy Markdown
Contributor

@kanow kanow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that locally, it works fine.

@kanow kanow merged commit 5b4a254 into main May 22, 2026
45 checks passed
@kanow kanow deleted the bugfix/fixer-fix branch May 22, 2026 07:04
@oliverklee oliverklee removed the request for review from sbuerk May 22, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working runTests.sh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

runTests.sh -s phpCsFixer doesn't actually fix the code

3 participants