docs(favorites): catch up on linked SQL folders v1.1#1001
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #999 (Linked SQL Folders). The original PR updated
docs/features/sql-favorites.mdxfor v1 but left a few gaps:sql-favorites.mdxclaimed linked folders are global only. Code already supports per-connection scope.autocomplete.mdxnever mentioned that linked-file@keywordparticipates in completion,icloud-sync.mdxdidn't say folder paths are per-Mac,sql-editor.mdxSQL Files section had no coverage of the conflict diff or the modification banner.Changes
docs/features/sql-favorites.mdx— rewrote the Linked SQL Folders section. Fixed scope claim. Added per-connection vs. global wording. Documented metadata dialog, live banner, diff sheet, drag-and-drop, encoding handling. Tightened prose throughout.docs/features/autocomplete.mdx— new "Favorite Keywords" subsection in Completion Types with link back to sql-favorites.docs/features/icloud-sync.mdx— added "Linked SQL Folders" row to the What syncs table, marked not-synced with rationale.docs/features/sql-editor.mdx— extended SQL Files with "External modifications" subsection (banner + diff sheet + the three actions) and a "Linked folders" pointer.Style notes
Followed CLAUDE.md writing rules:
grep '—'returns zero matches across all four files).seamless,robust,comprehensive, etc.) — verified withgrep -inE.Test plan
mintlify dev(or whatever local docs preview) renders all four pages without broken links or syntax errors.[Linked SQL Folders](/features/sql-favorites#linked-sql-folders)resolves correctly fromsql-editor.mdx.[SQL Favorites](/features/sql-favorites)resolves fromautocomplete.mdx.