fix: clear remaining test failures + content-less query tab regression

[datlechin]

Summary

Three loose ends from the AI audit work, two test-only and one real production fix.

What changed

test(ai-chat): resolve currentQuery via resolveTurnForWire instead of asserting on raw turn (b5bdac41)

AIChatViewModelMentionsTests.currentQueryResolved was asserting on userTurn.plainText directly after sendMessage(). The design intentionally keeps .attachment blocks raw until resolveTurnForWire runs (sibling tests Stored user turn keeps typed text raw and resolveTurnForWire expands attachments both pass and confirm this contract). Updated the test to call await vm.resolveTurnForWire(userTurn) first and assert on the wire-resolved text. Test-only change.

test(coordinator): seed lazy-load skip path with execution timestamp and registry eviction (0e2b0aec)

MainContentCoordinatorLazyLoadTests.skipsWhenAlreadyExecuting was missing setup that mirrors a real "tab is currently executing" state: rows seeded, lastExecutedAt set, registry evicted. Without those, the coordinator would compute needsLazyLoad = true for an unrelated reason, so the assertion was racing the actual early-return. Added the missing fixture state. Test-only change.

fix(session): do not auto-create empty query tab for content-less query payloads (59ac47bf)

SessionStateFactory.create was unconditionally calling tabMgr.addTab(...) on .query payloads. When the payload had nil initialQuery, nil tabTitle, and nil sourceFileURL (the "connection-only" case), users got an empty Query 1 tab they didn't ask for. Added a hasContent guard so empty .query payloads result in an empty tab manager, matching the existing .connectionOnlyPayload_createsEmptyTabManager test expectation. User-visible: opening a connection without an explicit tab payload no longer pre-populates an empty query tab.

Test plan

• xcodebuild build green
• swiftlint lint --strict clean on every touched file
• All three previously failing tests now pass
• No regressions in the broader test sweep (AIChatViewModelMentionsTests, MainContentCoordinatorLazyLoadTests, SessionStateFactoryTests, OpenTableTabTests)
• Manual: open a connection from Welcome screen, confirm a fresh Query 1 tab still appears (the isNewTab=true path is unchanged)
• Manual: restore a session that has no persisted tabs, confirm no empty Query 1 tab is created

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.