Conversation
…ding-driven focus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P1 #7: replace the imperative
UIApplication.shared.sendAction(#selector(UIResponder.resignFirstResponder), ...)keyboard dismiss inQueryEditorView.executeQueryDirectwith a SwiftUI@Binding<Bool>focus channel intoSQLHighlightTextView.What changes:
SQLHighlightTextView(UIViewRepresentable) gains an@Binding var isFocused: Boolparameter (default.constant(false)so existing call sites that don't care still compile)updateUIViewsyncs the binding into the wrappedUITextViewviabecomeFirstResponder()/resignFirstResponder()only when state actually divergestextViewDidBeginEditingandtextViewDidEndEditingto propagate user-driven focus changes back to the bindingQueryEditorViewadds@State private var editorFocused = false, passes$editorFocusedinto the editor, and setseditorFocused = falsebefore executing a query, dismissing the keyboardWhy a plain
@State Booland not@FocusState:@FocusState's projected value isFocusState<Bool>.Binding, which doesn't satisfy@Binding var isFocused: Bool. The canonical iOS pattern forUIViewRepresentablefocus is parent@State Boolplus two-way sync through the representable's update method and delegate callbacks. The user-visible behavior matches@FocusState: keyboard dismisses declaratively when state flips tofalse.Two
resignFirstResponder()calls remain insideSQLHighlightTextViewitself: one inupdateUIView(sync from binding) and one in the toolbar Done button's@objchandler. Both are UIKit-internal and not the imperative SwiftUI escape hatch this PR targets.Test plan
editorFocusedbecomes true (verify by adding a.onChangeprint if needed)editorFocusedbecomes false viatextViewDidEndEditing