chore(ios): P2 polish - strip headers, cleanup orphan UserDefaults, accessibility labels#1168
Merged
chore(ios): P2 polish - strip headers, cleanup orphan UserDefaults, accessibility labels#1168
Conversation
…lts, accessibility labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P2 polish pass bundling three independent items into one PR. Each item is small enough on its own that splitting into three PRs adds review overhead without payoff.
P2 #10 - Strip Xcode-generated file headers
Drop the 4-line
//\n// X.swift\n// TableProMobile\n//\nboilerplate from every iOS source file. CLAUDE.md rule: no comments. Six files (drivers + SSH) had an extra one-liner description after the header; those descriptions are stripped too since the type names are self-explanatory and any non-obvious purpose belongs in a///doc comment on the type, not as a floating top-of-file note.Touched 58 files in
TableProMobile/and 9 inTableProWidget/.P2 #9 - Cleanup orphan UserDefaults on connection delete
AppState.removeConnectionnow also callsclearPerConnectionPreferences(for:)which removes:lastTab.<uuid>(selected tab on Connected screen)lastDB.<uuid>(active database)lastSchema.<uuid>(active schema)lastQuery.<uuid>(last typed query in the editor)Previously, deleting a connection silently leaked these four
UserDefaultskeys forever. Repeated add and delete cycles built up unbounded keychain-adjacent state.P2 #8 - Accessibility labels on high-impact surfaces
Audit found 9 accessibility annotations across the entire app and zero hints. This pass adds the most-used surfaces:
TableRow(table list): combines type, name, and row count into a single accessibility element with hint "Opens table data"ConnectionRow(connection list): combines type, display name, host or SQLite filename, and tag name into a single element with hint "Opens this connection"accessibilityLabelOther toolbar items (Sort, Filter, Insert Row in DataBrowser; Edit Connection in ConnectedView) already had labels.
Test plan
importstatements (the strip is mechanical, but verify the diff in a couple of driver files)defaults readthe app's bundle ID: the fourlast*.<uuid>keys for that connection are gone