Conversation
…yManager.fetchHistory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hotfix for the build error introduced by PR #1176.
SearchQueryHistoryTool.searchHistorycallsQueryHistoryManager.shared.fetchHistory(...)withsince,until, andallowedConnectionIdsarguments. PR #1176 migrated that call site fromQueryHistoryStorage.sharedtoQueryHistoryManager.shared, butQueryHistoryManager.fetchHistoryexposed only the first five parameters (limit,offset,connectionId,searchText,dateFilter). Storage's signature includes three more (since,until,allowedConnectionIds).Compiler error:
This PR widens the Manager's
fetchHistoryto forward all eight parameters to Storage so the call site compiles unchanged. The new parameters all default tonil, so other callers (HistoryDataProvider,MCPConnectionBridge,HistoryPanelView) keep their current behavior.Test plan
search_query_historytool with date-range and allowedConnectionIds filtering returns the same results it did before refactor(storage): hide QueryHistoryStorage and SQLFavoriteStorage behind their manager facades #1176.