fix(welcome): wire WindowOpener bridge from all scenes to fix missing-window race#1213
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Welcome window sometimes failed to appear on launch and Dock-icon clicks did nothing. Console showed:
```
WindowOpener call queued; bridge not yet wired
WindowOpener call queued; bridge not yet wired
WindowOpener call queued; bridge not yet wired
```
…and the queue never drained.
Root cause
`WindowOpenerBridge` is the SwiftUI view that hands `openWindow` / `openSettings` closures to the AppKit-world `WindowOpener` singleton. It was mounted only in the Welcome scene and wired itself in `.onAppear { wireUp() }`.
If state restoration or a launch intent caused Welcome to be `orderOut`'d before its view body's first appearance, `.onAppear` never fired, the bridge never wired, and every subsequent `WindowOpener.shared.openWelcome()` call from `AppLaunchCoordinator` / `applicationShouldHandleReopen` / etc. was queued indefinitely. The app would launch with no visible window and Dock-icon clicks would silently queue more calls onto the dead queue.
Fix
Test plan