fix(connections): show inline connecting state and clean up on cancel (#1185)#1232
Merged
Conversation
e42d7e7 to
3397305
Compare
3397305 to
a6824c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContentUnavailableViewshowing the database type icon (with.symbolEffect(.pulse)), connection name, host:port, an in-line spinner, and a Cancel button.ensureConnectedtask and drops the.connectingsession entry when the user closes the editor window mid-connect, so the libpq result is discarded silently.WelcomeViewModel/ConnectionFormCoordinatorcheckWindowManager.hasOpenWindow(for:)and only present the alert when the editor window is still open.Closes #1185.
Test plan
192.168.79.78:5432): connecting state shows; clicking Cancel or the X closes the window cleanly with no ghost and no alert.