fix(plugin-mssql): keep FreeTDSConnection PluginKit-neutral so iOS builds#1361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The iOS Tests CI job fails to compile with
cannot find type 'SSLHandshakeError' in scopeatPlugins/MSSQLDriverPlugin/FreeTDSConnection.swift.FreeTDSConnection.swiftis compiled into two targets that link differentTableProPluginKitmodules:Plugins/TableProPluginKit/(hasSSLHandshakeError)TableProMobile→ the SPM product fromPackages/TableProCore/(does not haveSSLHandshakeError)The file header documents this and forbids PluginKit deps. #1310 added
import TableProPluginKitplus a classifier returningSSLHandshakeError, which compiles on macOS but breaks the iOS build.Fix
Restore the shared file to PluginKit-neutral and route SSL classification through the existing neutral error channel:
MSSQLCoreError(shared core) gains a neutralMSSQLTLSFailureKind;tlsHandshakeFailednow carries(kind, serverMessage).FreeTDSConnectiondrops the PluginKit import, classifies into the neutral kind, and throwsMSSQLCoreError.tlsHandshakeFailed.MSSQLPlugin(macOS only) maps the neutral kind back to the richSSLHandshakeErrorinconnect().MSSQLDriver(iOS only) updated for the new case signature.macOS behavior is unchanged: the app still receives the same
SSLHandshakeErrorwith its recovery suggestions. iOS now compiles and surfaces a neutral TLS handshake message.No CHANGELOG entry: macOS UX is unchanged and the broken iOS build never shipped.