fix(connections): safe mode level no longer resets when opening a table (#1351)#1376
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1351.
Problem
Changing the Safe Mode level from the toolbar didn't stick: opening a table (or any reconfigure of the connection) reset it back to the connection's saved default.
ConnectionToolbarState.update(from:)hard-setsafeModeLevel = connection.safeModeLevelevery time, andMainContentCommandActions.safeModeLevelalso read the saved default, so the live choice was lost.Fix
The live level now lives on the session, not just the saved connection:
ConnectionSessiongains asafeModeLevel, seeded fromconnection.safeModeLevelon connect.ConnectionToolbarState.update(from:)no longer overwritessafeModeLevel;syncFromSessionresolves it from the session (falling back to the connection default), so a reconfigure keeps the live value.onSafeModeChange→MainContentCoordinator.setSafeModeLevel, which updates both the toolbar state and the session (DatabaseManager.setSafeModeLevel).MainContentCommandActions.safeModeLevelreads the live toolbar state instead of the saved connection.Tests
ConnectionSessionTests(session seeds from the connection default) andConnectionToolbarStateTests(the live level survives anupdate(from:)and tracks the session).