feat(plugin-oracle): add SID connection option#1431
Merged
Conversation
datlechin
force-pushed
the
feat/oracle-sid
branch
from
e4524d1 to
38b683a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1425. Oracle connections can now connect by SID, not just service name. DataGrip and older 11g setups commonly use SID (
jdbc:oracle:thin:@host:port:SID), so imported connections that used a SID previously had no way to connect.Changes
.sid(...)or.serviceName(...)to OracleNIO accordingly. Validated against a live Oracle 11.2.0.2 XE instance using its SID.Compatibility
Existing connections default to Service Name, so they are unaffected. The connection-type field falls back to its default for connections saved before this change.