Skip to content

fix(hig): move Save as Favorite off Cmd+D to free the system Don't Save accelerator (#1490) #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 1 commit into from
May 30, 2026
+2 −1
Merged

fix(hig): move Save as Favorite off Cmd+D to free the system Don't Save accelerator (#1490) #1516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Save as Favorite moved from Cmd+D to Cmd+Control+D, so Cmd+D stays free for the system "Don't Save" action in save-changes dialogs. Rebindable in Settings, Keyboard. (#1490)
- The Tables sidebar bottom bar uses native macOS styling. The schema switcher is a borderless pull-down menu on the sidebar's own background instead of a wide gray bordered control, matching the Favorites footer, and switching schemas now goes through the same path as the toolbar so filters and the active tab stay in sync.
- The Maintenance submenu in the sidebar context menu is hidden when no maintenance operations are available or the target is read-only, instead of showing an empty disabled menu.
- The window minimum width now adjusts to the visible panes, so opening the inspector on a small window no longer pushes content off-screen.
Expand Down
2 changes: 1 addition & 1 deletion TablePro/Models/UI/KeyboardShortcutModels.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ struct KeyboardSettings: Codable, Equatable {
.duplicateRow: KeyCombo(key: "d", command: true, shift: true),
.truncateTable: KeyCombo(key: "delete", option: true, isSpecialKey: true),
.previewFKReference: KeyCombo(key: "space", isSpecialKey: true),
.saveAsFavorite: KeyCombo(key: "d", command: true),
.saveAsFavorite: KeyCombo(key: "d", command: true, control: true),
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid reusing the macOS lookup shortcut

This new default still collides with a macOS-provided text-editing shortcut: Control-Command-D is documented by Apple as “Show or hide the definition of the selected word.” In TablePro this menu item is installed globally via TableProApp’s Query menu, so while editing SQL or other text with canSaveAsFavorite true, the app action can take precedence over the standard Lookup behavior. Since this change is intended to move the action away from system accelerators, please choose a shortcut that is not already used by macOS text editing.

Useful? React with 👍 / 👎.


// View
.toggleTableBrowser: KeyCombo(key: "0", command: true),
Expand Down
Loading