feat(toolbar): make connection selectors navigational and move refresh/save to the trailing side#1549
Merged
Merged
Conversation
…h/save to the trailing side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reworks the main window toolbar layout:
connectionGroup) are now anisNavigationalgroup, so AppKit pins them to the leading side and keeps them out of normal overflow.toolbarIdentifiertocom.TablePro.main.toolbar.v2. Reordering default items has no effect for existing users unless the identifier changes, because AppKit autosave restores the previously persisted layout. The bump forces a one-time reset to the new default arrangement.Why
Groups navigation-style controls where macOS expects them and moves the action buttons next to the other action controls.
Notes
Localizable.xcstringspicks up strings extracted from recent work (JSON import, toolbar, password sources).MainWindowToolbarValidationTests.toolbarIdentifierIsStablealready expected.v2; the source bump makes it pass. FullMainWindowToolbarValidationTestssuite passes.Test plan
MainWindowToolbarValidationTestspassesswiftlint lint --strictclean on changed files