-
-
Notifications
You must be signed in to change notification settings - Fork 279
fix(plugins): self-heal incompatible drivers at connect instead of blocking (#1552) #1555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
78aafc2
fix(plugins): gate the rejected-plugin Update button and cap the unlo…
datlechin 9dc5720
refactor(plugins): extract a pure rejected-plugin action resolver and…
datlechin 697644e
fix(plugins): self-heal incompatible drivers at connect instead of bl…
datlechin 3854120
perf(plugins): reconcile only the connecting driver at connect, debou…
datlechin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // | ||
| // PluginManager+NetworkMonitor.swift | ||
| // TablePro | ||
| // | ||
|
|
||
| import Network | ||
|
|
||
| extension PluginManager { | ||
| func startNetworkReachabilityMonitor() { | ||
| guard pluginNetworkMonitor == nil else { return } | ||
| let monitor = NWPathMonitor() | ||
| pluginNetworkMonitor = monitor | ||
| monitor.pathUpdateHandler = { [weak self] path in | ||
| let satisfied = path.status == .satisfied | ||
| Task { @MainActor [weak self] in | ||
| self?.handleNetworkPathChange(satisfied: satisfied) | ||
| } | ||
| } | ||
| monitor.start(queue: DispatchQueue(label: "com.TablePro.pluginNetworkMonitor")) | ||
| } | ||
|
|
||
| private func handleNetworkPathChange(satisfied: Bool) { | ||
| defer { lastNetworkSatisfied = satisfied } | ||
| guard satisfied, !lastNetworkSatisfied else { return } | ||
| retriggerReconciliation() | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the registry entry still has an old binary in the app's PluginKit range but its plugin-level
minAppVersionhas moved past the running app, this returnsupdateAvailableand the rejected-plugin UI shows anUpdate Nowbutton. That update cannot succeed becausevalidateRegistryCompatibilityrejectsregistryPlugin.minAppVersionbefore downloading, so older app versions with retained compatible binaries get a misleading/retryable update path instead of theUpdate TablePropath.Useful? React with 👍 / 👎.