feat: extract export formats into plugin bundles#213
Merged
Conversation
Extract all 5 built-in export formats (CSV, JSON, SQL, XLSX, MQL) into .tableplugin bundles, making the export system plugin-based and extensible. - Add ExportFormatPlugin protocol, PluginExportDataSource, PluginExportProgress, and shared utilities to TableProPluginKit - Create 5 export plugin bundles with self-contained models, options views, and export logic - Simplify ExportService to thin orchestrator delegating to plugins - Dynamic format picker in ExportDialog filtered by database type - Generic per-table option columns replacing hardcoded SQL/MQL columns - Fix test parallelization causing false failures (scheme parallelizable=NO) - Update tests for new plugin-based export API
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Remove duplicate finalizeTable() calls from CSV/SQL/JSON/MQL helpers - Add bundle: .main to String(localized:) in plugin option views - Clear optionValues on format switch to prevent MQL/SQL column mismatch - Add progress update coalescing to prevent main actor flooding - Extract createFileHandle to PluginExportUtilities (DRY)
- Replace PluginManager dependency in MSSQLDriverTests with a mock PluginDatabaseDriver to avoid plugin loading issues in parallel runs - Add .serialized trait to CompletionEngineTests to prevent data race on SQLKeywords statics - Restore parallelizable = YES in test scheme
- Surface DDL failure warnings from SQLExportPlugin via new protocol warnings property on ExportFormatPlugin - Propagate Swift Task cancellation in PluginExportProgress.checkCancellation - Pass databaseName through writeMQLIndexes instead of hardcoding "" - Add bundle: .main to String(localized:) in CSVExportModels displayName - Populate optionValues with plugin defaults on format switch - Wrap per-table sequence/type fetch in do/catch for fault tolerance - Restore original format picker order (csv, json, sql, xlsx, mql)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.tablepluginbundles, making the export system plugin-based and extensible by third partiesExportFormatPluginprotocol,PluginExportDataSource,PluginExportProgress, and shared utilities to TableProPluginKitExportServiceto a thin orchestrator that delegates to plugins; dynamic format picker in Export dialog filtered by database type compatibilityparallelizable=NOin scheme)Test plan