Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdded registry metadata support to the plugin manager with persistent storage for plugin versions. The system now captures metadata during installation from the registry, stores it atomically, and prefers registry-stored versions during plugin loading, while the Changes
Sequence DiagramsequenceDiagram
participant Caller
participant PluginManager
participant Registry as Registry Source
participant FileSystem as File Storage
participant PluginEntry as Plugin Entry
Caller->>PluginManager: installFromRegistry(registryPlugin)
PluginManager->>PluginManager: installPlugin(from: url)
PluginManager->>PluginEntry: create entry with initial version
PluginManager->>FileSystem: saveRegistryMetadata(version, id, url)
FileSystem-->>PluginManager: metadata saved
PluginManager->>PluginEntry: update version to registry version
PluginManager->>Caller: return updated entry
Note over PluginManager,FileSystem: Later: Plugin Loading
Caller->>PluginManager: loadBundlesOffMain()
PluginManager->>FileSystem: read metadata (.metadata.json)
FileSystem-->>PluginManager: stored version (if exists)
PluginManager->>PluginEntry: use metadata version or fallback
PluginManager-->>Caller: loaded plugins with correct versions
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
principalClass.pluginVersion(hardcoded in plugin source).metadata.jsonsidecar file when installing from registry, containing the actual registry versionTest plan
Summary by CodeRabbit