fix: bundle libpq and transitive dylibs into app for distribution#44
Merged
fix: bundle libpq and transitive dylibs into app for distribution#44
Conversation
The app crashed at launch on machines without Homebrew because libpq (and its dependencies: OpenSSL, Kerberos) were dynamically linked with hardcoded Homebrew paths. Add a bundle_dylibs post-build step that copies non-system dylibs into Contents/Frameworks/ and rewrites all load paths to @executable_path/../Frameworks/. CI now also verifies no Homebrew references remain in the final binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SIGABRT,DYLD Library missing: libpq.5.dylib) on machines without Homebrewbundle_dylibs()post-build step tobuild-release.shthat recursively copies non-system dylibs (libpq, OpenSSL, Kerberos) intoContents/Frameworks/and rewrites load paths to@executable_path/../Frameworks/Test plan
scripts/build-release.sh arm64and verifyContents/Frameworks/contains bundled dylibsotool -Lon the output binary and confirm no/opt/homebrew/or/usr/local/opt/references