refactor: replace CodeEditSourceEditor with native NSTextView editor#471
Open
refactor: replace CodeEditSourceEditor with native NSTextView editor#471
Conversation
Replace the 252-file CodeEditSourceEditor/CodeEditTextView third-party dependency (25K+ LOC) with a native NSTextView-based SQL editor (~1,500 LOC). - TPTextView: NSTextView subclass with Apple-standard horizontal scrolling, built-in Find Bar, auto-indent, bracket matching - TPSyntaxHighlighter: temporary attributes on NSLayoutManager (Apple pattern) - TPLineNumberView: NSRulerView subclass for line numbers - TPEditorView: SwiftUI NSViewRepresentable wrapper - Adapt Vim mode, AI suggestions, context menu to NSTextView API - Replace CursorPosition (CESS type) with NSRange throughout - Remove LocalPackages/CodeEditSourceEditor (1.5GB) - Remove LocalPackages/CodeEditLanguages Fixes #448 (horizontal scrolling broken due to CETV variable shadowing bug) Fixes #448 (Home/End keys not working)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxLineWidthwas never updatedNew editor architecture (Apple-standard patterns)
Views/Editor/TPTextView.swiftViews/Editor/TPSyntaxHighlighter.swiftViews/Editor/TPLineNumberView.swiftViews/Editor/TPEditorView.swiftViews/Editor/TPEditorTheme.swiftViews/Editor/TPEditorConfiguration.swiftViews/Editor/TPEditorDelegate.swiftWhat we gain for free from NSTextView
NSTextContainer.widthTracksTextView = false(no workarounds)usesFindBar = true(built-in, zero code)allowsUndo = true(built-in NSUndoManager)allowsNonContiguousLayout = trueFiles changed
CursorPositionwithNSRangeTest plan
Closes #448