fix: file picker appears behind connection form window#588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.level = .floatingfrom the connection form window..floatingis designed for utility/inspector panels (Xcode inspector, Photoshop palettes), not form dialogs. This causedNSOpenPanel(which opens at.normallevel) to appear behind the connection form.NSOpenPanelcalls in connection form views frompanel.begin { }topanel.beginSheetModal(for:)— the standard macOS pattern for file dialogs in form windows. The picker now slides down as a sheet attached to the form.Closes #587
Test plan