Skip to content

fix: prevent infinite alert loop when table tab query fails #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 1 commit into from
Apr 6, 2026
+3 −0
Merged

fix: prevent infinite alert loop when table tab query fails #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions TablePro/Views/Main/Extensions/MainContentCoordinator+QueryHelpers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,7 @@ extension MainContentCoordinator {
var errTab = tabManager.tabs[idx]
errTab.errorMessage = error.localizedDescription
errTab.isExecuting = false
errTab.lastExecutedAt = Date()
tabManager.tabs[idx] = errTab
}
toolbarState.setExecuting(false)
Expand Down
1 change: 1 addition & 0 deletions TablePro/Views/Main/Extensions/MainContentCoordinator+TabSwitch.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ extension MainContentCoordinator {
let needsLazyQuery = newTab.tabType == .table
&& (newTab.resultRows.isEmpty || isEvicted)
&& (newTab.lastExecutedAt == nil || isEvicted)
&& newTab.errorMessage == nil
&& !newTab.query.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty

if needsLazyQuery {
Expand Down
1 change: 1 addition & 0 deletions TablePro/Views/Main/MainContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ struct MainContentView: View {
tab.tabType == .table
&& (tab.resultRows.isEmpty || tab.rowBuffer.isEvicted)
&& (tab.lastExecutedAt == nil || tab.rowBuffer.isEvicted)
&& tab.errorMessage == nil
&& !tab.query.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty
} ?? false
if needsLazyLoad && !hasPendingEdits && isConnected {
Expand Down
Loading