Skip to content

fix: log rollback errors and use O(1) string length#615

Merged
datlechin merged 1 commit intomainfrom
fix/audit-silent-errors-and-perf
Apr 7, 2026
Merged

fix: log rollback errors and use O(1) string length#615
datlechin merged 1 commit intomainfrom
fix/audit-silent-errors-and-perf

Conversation

@datlechin
Copy link
Copy Markdown
Member

Summary

  • DatabaseManager+Schema.swift: try? on rollbackTransaction() now wrapped in do/catch with logger.error so rollback failures are visible instead of silently swallowed
  • CompletionTextField.swift: string.count (O(n) in Swift) replaced with (string as NSString).length (O(1))
  • EditorEventRouter.swift: Added clarifying comment on why DispatchQueue.main.async inside MainActor.assumeIsolated is intentional (coalesces rapid didUpdateNotification fires)

Test plan

  • Build succeeds
  • Filter text field autocomplete still works correctly
  • SQL editor cursor/first-responder behavior unchanged

@datlechin datlechin merged commit 72a4d36 into main Apr 7, 2026
1 check passed
@datlechin datlechin deleted the fix/audit-silent-errors-and-perf branch April 7, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant