fix: resolve 16 issues from deep analysis of TableProMobile#624
Merged
fix: resolve 16 issues from deep analysis of TableProMobile#624
Conversation
Critical: - Fix @unchecked Sendable data race on serverVersion in all drivers - Fix SSHTunnel use-after-free: acquire sessionLock before freeing session - Fix ConnectionFormView save proceeding when Keychain storage fails High: - Fix sync merge always overwriting local with remote (respect dirty flags) - Fix concurrent reconnect on rapid foreground/background cycles - Fix ForEach crash on duplicate column names in RowDetailView - Fix stale row data after pagination in DataBrowserView Medium: - Fix MySQL string escaping (add \0, \n, \r, \x1a, " escaping) - Fix onboarding sync showing empty list (await sync before completing) - Fix TagManagementView duplicate toolbar items - Fix ConnectionListView NavigationSplitView detail not populating on iPad - Document widget SharedConnectionStore file protection trade-off Low: - Fix table name quoting in query template - Fix NaN/Infinity producing invalid JSON in ClipboardExporter - Fix PostgreSQL version format for 10+ (two-component, not three) - Add memory warning handler to DataBrowserView
- SSHTunnel: restore non-blocking session free (detached thread) to avoid actor stall, add aliveFlag guard inside locked relay sections to close the use-after-free window - SQLBuilder: remove incorrect double-quote escaping from escapeString - PostgreSQLDriver: revert OID number separators (protocol constants), use swiftlint:disable block instead - DataBrowserView: fix inconsistent memory warning message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan