Merged
Conversation
…ces, unify resolution, fix view layer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architecture cleanup for the AI system — 7 improvements across 9 files, net -44 lines.
A5: Deduplicate provider code
collectErrorBody()(9 lines × 3 providers) intoAIProviderprotocol extensionmapHTTPError()base implementation intoAIProviderErrorstatic methodA4: Cache provider instances
AIProviderFactorynow caches providers keyed by(config.id, apiKey)invalidateCache()andinvalidateCache(for:)methodsAISettingsViewon provider save/deleteA3: Unified provider resolution
AIProviderFactory.ResolvedProviderstruct andresolve(for:settings:)convenienceresolveProvider→resolveModel→createProviderpatternInlineSuggestionManagerandAIChatViewModelA8: Use AIPromptTemplates
handleFixError,handleExplainSelection,handleOptimizeSelectionnow useAIPromptTemplatesinstead of building prompts inlinequeryLanguageandqueryTypeNamecomputed propertiesA2: Move schema fetch to ViewModel
fetchSchemaContext()fromAIChatPanelView(View) toAIChatViewModelawait viewModel.fetchSchemaContext()in.task(id:)UI1: Use shared EmptyStateView
ContentUnavailableViewwith app'sEmptyStateViewcomponentThemeEngineacross all panelsSettingsLinkhack with raw UserDefaults keyUI2: Fix scroll-to-bottom
Color.clearanchor element andisNearBottomstate trackingDispatchQueue.main.asyncworkaroundsscrollToBottom(proxy:)helper replaces 4 duplicate scroll blocksTest plan