Skip to content

Fix icon alignment and hit targets per macOS HIG#632

Merged
datlechin merged 3 commits intomainfrom
fix/icon-alignment-hit-targets
Apr 8, 2026
Merged

Fix icon alignment and hit targets per macOS HIG#632
datlechin merged 3 commits intomainfrom
fix/icon-alignment-hit-targets

Conversation

@datlechin
Copy link
Copy Markdown
Collaborator

Summary

  • Add .frame(width: 24, height: 24) to all icon-only borderless/plain buttons for macOS HIG minimum hit targets (was ~14pt, now 24pt)
  • Replace hardcoded .font(.system(size: N)) on SF Symbols with semantic styles (.font(.largeTitle), .font(.title), .imageScale()) or let the system handle sizing via .controlSize(.small)
  • Replace hardcoded Color.red/.yellow/.orange with system semantic colors (Color(nsColor: .systemRed), etc.)
  • Add .contentShape(Circle()) to onboarding pagination dots for proper tap targets
  • Remove unnecessary manual font sizing from toolbar sub-components (SafeModeBadgeView, ConnectionStatusView) — let the native toolbar system handle icon sizing

Closes #629

Test plan

  • Open a table tab, toggle filters — verify +/- buttons are easy to click and visually aligned
  • Check pagination chevrons and settings gear in status bar
  • Check safe mode badge in toolbar
  • Check SQL preview sheet close button
  • Check query editor toolbar (clear, format buttons)
  • Check EXPLAIN result font size buttons
  • Check DDL view font size buttons in table structure
  • Check history panel clear button
  • Check database switcher refresh/create buttons
  • Check AI settings provider list +/-/edit buttons
  • Check favorites sidebar bottom toolbar buttons
  • Check inline error banner copy/dismiss buttons
  • Check onboarding pagination dots are tappable

@datlechin datlechin merged commit 3e20bc4 into main Apr 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icons are not optically aligned

1 participant