feat: ER diagram visualization with Sugiyama layout#651
Merged
Conversation
… during view update
… and node repositioning
…or 300+ table performance
…across ER diagram and query plan
…gram - Extract ERDiagramNodeRenderer from View (100+ lines drawing logic → enum with named constants) - Add @ObservationIgnored to 9 internal ViewModel properties (prevents 60fps spurious redraws) - Fix Timer actor bridge with MainActor.assumeIsolated - Fix NSCursor push/pop stack corruption with state tracking - Replace DispatchQueue.main.asyncAfter timing hack with signal-based needsInitialFit - Cache canvasSize as stored property (was O(n) computed per access) - Consolidate zoom(to:anchor:) — pinch and buttons share one code path - Remove dead nodeHeights dictionary (never written) - Extract makeExportView() — dedup export/clipboard rendering - Capture graph state before Canvas closure (correct observation dependencies) - Add @mainactor to ERDiagramPositionStorage - Extract ResolvedEdge struct from anonymous 5-tuple in edge renderer - Port routing: use actual edge gap instead of center distance for port selection - Add fit-to-window, Cmd+scroll zoom, Cmd+C copy, accessibility labels, empty state - Fix view identity reuse causing "Loading forever" on second ER diagram open - Delete dead ERTableNodeView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #186
New files (9)
ERDiagramModels.swift— graph data modelERDiagramLayout.swift— Sugiyama layout algorithmERDiagramPositionStorage.swift— UserDefaults persistenceERDiagramViewModel.swift— load, layout, drag, compact, exportERDiagramView.swift— single Canvas with imperative drawing + manual hit-testERTableNodeView.swift— SwiftUI node view (used for export)ERDiagramEdgeRenderer.swift— crow's foot edge drawingERDiagramToolbar.swift— zoom, compact, reset, export controlsMainContentCoordinator+ERDiagram.swift— tab opening logicTest plan