fix: query tab title incorrectly shows table name after execution (#668)#670
Merged
fix: query tab title incorrectly shows table name after execution (#668)#670
Conversation
Root cause: updateWindowTitleAndFileState() used tab.tableName as the window title for ALL tab types. After executing SELECT * FROM users, tableName="users" was set (correct for edit support), but the window title also became "users" instead of "Query 1". This caused sidebar "open table" to match the query tab's window by title, switching to it instead of opening a new table tab. Fix: only use tableName as window title for .table tabs. For .query tabs, use tab.title (the stable display name like "Query 1").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix query tab's window title changing to the executed table name, which also breaks sidebar table navigation.
Closes #668
Root Cause
updateWindowTitleAndFileState()usedselectedTab?.tableNameas the window title regardless of tab type. AfterSELECT * FROM users,tableName = "users"is set (needed for edit support), but the window title also became"users".This caused
openTableTab's window dedup check (window.title == tableName) to match the query tab, preventing new table tabs from opening.Fix
One line: guard
tableNameusage ontabType == .table. Query tabs usetab.title("Query 1") as the window title.Test plan
SELECT * FROM usersin query tab: window title stays "Query 1" (not "users")