fix(ios): remove segmented control background and fix reconnect lifecycle#681
Merged
fix(ios): remove segmented control background and fix reconnect lifecycle#681
Conversation
…ycle - Remove .background(.bar) from segmented tab picker for cleaner look - Fix infinite connecting loop when navigating back to same connection - Add .onAppear reconnect when driver session is lost - Guard against session reuse resetting isConnecting state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.background(.bar)from segmented tab picker for cleaner look.onAppearreconnect when driver session is lost after backgroundChanges
ConnectedView.swift: Remove bar background from segmented picker. Addguard session == nilearly return inconnect()to prevent re-triggering on reuse. Add.onAppearhandler to detect dead sessions and reconnect.Test plan