fix: resolve AI chat hang caused by main-actor-bound streaming (#735)#738
Merged
fix: resolve AI chat hang caused by main-actor-bound streaming (#735)#738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@MainActorusingTask.detachedwith explicitMainActor.runfor state mutations — fixes the primary hangTaskGroup) instead of firing all 20 at once against a serial driver connectionAnthropicProvider(3→1 parse per SSE line) andOpenAICompatibleProvider(2→1 parse per SSE line)onChangewith stream-end scroll to eliminate 50-100+ layout passes/sec during streamingAIProviderFactorycache withOSAllocatedUnfairLockfor thread safety@MainActorfromAISchemaContext.buildSystemPrompt— passeditorLanguage/queryLanguageNameas params insteadstartStreamingnot cancelling existing stream before starting a new onefetchSchemaContextrace when tables change rapidly (store + cancel task)cancelStreamusingmessages.lastinstead ofstreamingAssistantIDfor placeholder removalerrorevents (e.g.,overloaded_error) instead of silently ignoring themCloses #735
Test plan