fix: persist SSH jumphost and tunnel mode in connections.json#793
Merged
fix: persist SSH jumphost and tunnel mode in connections.json#793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #790. Partial fix for #780.
Root cause of #790:
StoredConnectionused flat scalar fields for SSH config (sshHost,sshPort, etc.) but never persistedjumpHostsorsshTunnelMode. Every save/load cycle silently dropped all jump host configuration. First connect worked (in-memory object correct), but reconnecting after app restart failed becauseconnections.jsonhad no jumphost data.Changes
StoredConnection —
sshTunnelModeJsonfield:sshTunnelModeJson: Data?that encodes the fullSSHTunnelModeenum (already Codable, includes inline config with jumpHosts, profile with snapshot)connections.jsonfilesdecodeIfPresentreturning nil, legacy flat-field path runs unchanged. Next save writes the blob.KeychainHelper —
loadWithStatus:KeychainLoadResultenum:.success(Data),.notFound,.locked,.error(OSStatus)loadWithStatus(key:)that distinguisheserrSecInteractionNotAllowed(Keychain locked before first unlock after reboot) fromerrSecItemNotFoundload(key:) -> Data?preserved for backward compatduplicateConnection — pass sshTunnelMode:
sshTunnelMode: connection.sshTunnelModeexplicitly instead of relying on auto-derive logicExport — sshProfileId:
sshProfileId: String?toExportableConnectionTest plan
connections.jsonwithoutsshTunnelModeJsonkey loads correctly (flat fields used)