Conversation
… tab persistence on schema switch
…ad Redis saveLastDatabase
…plicationWillTerminate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #777
Summary
Full rewrite of the database/schema switching system. Fixes 8 bugs across persistence, encapsulation, and crash safety.
Fixes
postConnectActions)clearCachedDatawas nilingcurrentDatabase)selectDatabaseFromConnectionFieldset state before error check (Redis state corruption)lastDatabaseinstead oflastSchema)applicationWillTerminate(Cmd+R in Xcode lost current connection)Architecture
DatabaseManager.switchDatabase(to:for:)andswitchSchema(to:for:)own driver call + session state + persistencePostConnectAction.selectSchemaFromLastSessionfor PostgreSQL/Redshift/BigQuerypostConnectActionsexplicitly (not relying on registry defaults)activeSessions.didSetTest plan