fix: selection highlight on last line and add Execute All shortcut (#770)#799
Merged
fix: selection highlight on last line and add Execute All shortcut (#770)#799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #770 (items 2 and 3).
Selection highlight fix: The blue selection mask now correctly covers the last line when using Cmd+A or block selection. Root cause was in
TextSelectionManager+FillRects.swiftwhererectForOffsetreturns nil at the document boundary, causing the last line's fill rect to be skipped entirely.Execute All Statements (Cmd+Shift+Enter): New shortcut to run all statements in the editor sequentially, regardless of cursor position or selection. Industry-standard shortcut matching DBeaver and DataGrip. The safe mode dispatch logic was extracted from
runQuery()into a shareddispatchStatements()helper to avoid duplication.Changes
TextSelectionManager+FillRects.swift— fallback rect at document end instead ofcontinueSQLEditorView.swift— bottom content inset 0 → 8 for visual breathing roomMainContentCoordinator+ExecuteAll.swift— new extension withrunAllStatements()and extracteddispatchStatements()MainContentCoordinator.swift—runQuery()now calls shareddispatchStatements()TableProApp.swift— "Execute All Statements" menu item with Cmd+Shift+EnterMainContentCommandActions.swift—runAllStatements()passthroughTest plan
SELECT 1; SELECT 2; SELECT 3;, cursor on line 1, press Cmd+Shift+Enter — all 3 execute (3 result tabs)SELECT 1executes (statement at cursor)