feat: ALTER TABLE DDL generation for all database plugins#804
Merged
feat: ALTER TABLE DDL generation for all database plugins#804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supportsAddColumn,supportsModifyColumn,supportsDropColumn,supportsRenameColumn,supportsAddIndex,supportsDropIndex,supportsModifyPrimaryKey) toDriverPluginprotocolsupportsDropDatabasesync gap between Plugins and Packages copies ofDriverPlugin.swiftCloses #803
Details
MySQL:
CHANGE COLUMN(rename) /MODIFY COLUMN(same name), full column definition rebuild reusingbuildColumnDefinitionSQLPostgreSQL: Multi-statement modify — diffs old vs new column, emits only changed properties (
RENAME COLUMN,ALTER COLUMN TYPE,SET/DROP NOT NULL,SET/DROP DEFAULT,COMMENT ON COLUMN)SQLite: Limited to natively supported operations — ADD COLUMN, RENAME COLUMN, DROP COLUMN, CREATE/DROP INDEX. Modify column type/nullable/default returns nil (no table rebuild).
ClickHouse: ADD/MODIFY/DROP COLUMN with
Nullable()wrapping, data-skipping index support. No FK/PK (immutable ORDER BY).MSSQL: Complex modify — rename via
sp_renamefirst, dynamic SQL to discover and drop default constraints, thenALTER COLUMN, then add new default constraint.DuckDB: PostgreSQL-compatible syntax, full support.
Cassandra/ScyllaDB: ADD/DROP column only (CQL limitations).
Oracle: Full support with Oracle-specific syntax (
ADD (col TYPE),MODIFY (col TYPE),RENAME COLUMN).Test plan