fix: use Icon Composer .icon for proper macOS icon padding#817
Merged
fix: use Icon Composer .icon for proper macOS icon padding#817
Conversation
Upgrade CI Xcode from 26.2 to 26.5 where actool no longer crashes on .icon files in headless environments. Remove the workaround that deleted AppIcon.icon and fell back to unpadded .appiconset PNGs. Fixes #769
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-release.shworkaround that deletedAppIcon.iconand fell back to unpadded.appiconsetPNGs.iconfiles correctly in headless CI on Xcode 26.5, producing proper ~7% padding around the squircleContext
The app icon appeared oversized in the Dock (#769) because CI deleted the Icon Composer
.iconfile (due to an actool crash on Xcode 26.0) and used raw.appiconsetPNGs with 0% padding. Apple's icon grid expects ~10% padding around the squircle.Test plan
workflow_dispatchon this branch: https://github.com/TableProApp/TablePro/actions/runs/24666415874.iconwithout crashing)Fixes #769