Skip to content

fix(ios): TabView navigation fixes and code review cleanup#870

Merged
datlechin merged 3 commits intomainfrom
fix/ios-review-fixes
Apr 25, 2026
Merged

fix(ios): TabView navigation fixes and code review cleanup#870
datlechin merged 3 commits intomainfrom
fix/ios-review-fixes

Conversation

@datlechin
Copy link
Copy Markdown
Member

Summary

  • Fix NavigationStack/TabView architecture: single NavigationStack wrapping TabView instead of per-tab stacks. Resolves toolbar and title not displaying on iPhone.
  • Move QueryEditorView run button and menu inline (TabView blocks toolbar propagation)
  • Dynamic navigationTitle per tab (Tables/Query show connection name, History/Settings show tab name)
  • Cache coordinators in ConnectionListView to preserve state across back/forward navigation
  • Load databases/schemas before setting phase to prevent toolbar flicker
  • Fix coordinator race condition on mid-connect navigation
  • Fix reorderSection sort corruption in grouped connection list
  • Localize alert/dialog strings in QueryEditorView and QueryHistoryView
  • Cancel pending tasks on view disappear (saveQueryTask, dismissSuccessTask)
  • Refresh columnDetails on initial DataBrowserView load
  • Add accessibility labels to keyboard shortcut buttons
  • Add Sendable conformance to ConnectedTab
  • Add systemGroupedBackground to RowDetailView

Test plan

  • Connect to a database, verify toolbar (database switcher, schema icon) appears
  • Switch between tabs, verify title updates (connection name / History / Settings)
  • Query tab: inline Run button visible, tap to execute, ellipsis menu works
  • Tables tab: tap a table, DataBrowserView pushes with native animation
  • Back to connection list, tap same connection again, connects without issues
  • RowDetailView: no white background bleeding behind nav/bottom bars
  • Grouped connections: reorder within a group, verify other groups unchanged
  • iPad: verify all tabs work with sidebar layout

- Move QueryEditorView run button and menu inline (TabView blocks toolbar propagation)
- Dynamic navigationTitle per tab (Tables/Query show connection name, History/Settings show tab name)
- Remove dead .navigationTitle/.toolbar from tab content views
- Show connection name in nav bar during connecting phase
- Rename tablesPath to navigationPath (shared across tabs)
- Remove duplicate safe mode icon from query action bar
- Add Sendable conformance to ConnectedTab
- Add .environment(coordinator) to Settings tab for consistency
- Fix coordinator race condition on mid-connect navigation
- Add accessibility labels to keyboard shortcut buttons
- Localize alert/dialog strings in QueryEditorView and QueryHistoryView
- Cancel saveQueryTask on QueryEditorView disappear
- Fix reorderSection sort corruption in grouped connection list
- Refresh columnDetails on initial DataBrowserView load
- Cancel dismissSuccessTask on RowDetailView disappear
- Add systemGroupedBackground to RowDetailView
@datlechin datlechin force-pushed the fix/ios-review-fixes branch from d2fb3c6 to f118ebd Compare April 25, 2026 17:10
@datlechin datlechin merged commit dd82839 into main Apr 25, 2026
2 checks passed
@datlechin datlechin deleted the fix/ios-review-fixes branch April 25, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant