fix(ios): TabView navigation fixes and code review cleanup#870
Merged
fix(ios): TabView navigation fixes and code review cleanup#870
Conversation
- Move QueryEditorView run button and menu inline (TabView blocks toolbar propagation) - Dynamic navigationTitle per tab (Tables/Query show connection name, History/Settings show tab name) - Remove dead .navigationTitle/.toolbar from tab content views - Show connection name in nav bar during connecting phase - Rename tablesPath to navigationPath (shared across tabs) - Remove duplicate safe mode icon from query action bar - Add Sendable conformance to ConnectedTab
- Add .environment(coordinator) to Settings tab for consistency - Fix coordinator race condition on mid-connect navigation - Add accessibility labels to keyboard shortcut buttons - Localize alert/dialog strings in QueryEditorView and QueryHistoryView - Cancel saveQueryTask on QueryEditorView disappear - Fix reorderSection sort corruption in grouped connection list - Refresh columnDetails on initial DataBrowserView load - Cancel dismissSuccessTask on RowDetailView disappear - Add systemGroupedBackground to RowDetailView
d2fb3c6 to
f118ebd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan