refactor(datagrid): migrate callers to TableRows + delete legacy stack#931

Merged

datlechin merged 31 commits intomainfrom

refactor/datagrid-phase4c2-migrate-callers

Apr 29, 2026

Commits on Apr 28, 2026

refactor(datagrid): introduce TableRowsStore alongside RowDataStore
datlechin
committed
refactor(datagrid): introduce TableRowsController to drive NSTableView from Delta
datlechin
committed
refactor(datagrid): mirror result delivery writes into TableRowsStore
datlechin
committed
refactor(datagrid): switch JSON view and export to read TableRows
datlechin
committed
refactor(datagrid): switch sidebar reads to TableRows
datlechin
committed
refactor(datagrid): switch NSTableView delegate reads to TableRows
datlechin
committed
refactor(datagrid): route cell edits through TableRows.edit and Delta
datlechin
committed
refactor(datagrid): RowOperationsManager mutates TableRows and returns Delta
datlechin
committed
refactor(datagrid): undo replay returns Delta and supports non-tail insert
datlechin
committed
refactor(datagrid): sort moves to controller keyed by Row.id
datlechin
committed
refactor(datagrid): display cache moves to coordinator keyed by Row.id
datlechin
committed
refactor(datagrid): replace RowBuffer with TableRows; delete legacy row stack
datlechin
committed
test(datagrid): update fixtures for RowDeltaApplying.applyDelta and StatusBarSnapshot rename
datlechin
committed
fix(favorites): qualify ORDER BY columns in FTS-joined search query
datlechin
committed
fix(datagrid): guard commitCellEdit against re-entry from reload-driven resignFirstResponder
datlechin
committed
fix(datagrid): dispatch rowsInserted delta from loadMoreRows and read offset inside mutation
datlechin
committed
fix(datagrid): dispatch fullReplace delta from fetchAllRows
datlechin
committed
fix(datagrid): dispatch cellChanged delta from updateCellInTab
datlechin
committed
fix(datagrid): remove TableRows entry on individual tab close
datlechin
committed
refactor(datagrid): rebuildColumnMetadataCache reads live TableRows
datlechin
committed
style(datagrid): drop doc comments per no-comments rule
datlechin
committed
fix(datagrid): sync ResultSet snapshot with store on every mutation
datlechin
committed
fix(datagrid): unwrap optional result from addNewRow/duplicateRow
datlechin
committed
fix(datagrid): clear modified cell highlight on undo, keep FK metadata across reloads
datlechin
committed
perf(datagrid): stop syncing ResultSet snapshot on every mutation
datlechin
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(datagrid): migrate callers to TableRows + delete legacy stack#931

refactor(datagrid): migrate callers to TableRows + delete legacy stack#931
datlechin merged 31 commits intomainfrom
refactor/datagrid-phase4c2-migrate-callers

Commits on Apr 28, 2026

refactor(datagrid): introduce TableRowsStore alongside RowDataStore

refactor(datagrid): introduce TableRowsController to drive NSTableView from Delta

refactor(datagrid): mirror result delivery writes into TableRowsStore

refactor(datagrid): switch JSON view and export to read TableRows

refactor(datagrid): switch sidebar reads to TableRows

refactor(datagrid): switch NSTableView delegate reads to TableRows

refactor(datagrid): route cell edits through TableRows.edit and Delta

refactor(datagrid): RowOperationsManager mutates TableRows and returns Delta

refactor(datagrid): undo replay returns Delta and supports non-tail insert

refactor(datagrid): sort moves to controller keyed by Row.id

refactor(datagrid): display cache moves to coordinator keyed by Row.id

refactor(datagrid): replace RowBuffer with TableRows; delete legacy row stack

test(datagrid): update fixtures for RowDeltaApplying.applyDelta and StatusBarSnapshot rename

fix(favorites): qualify ORDER BY columns in FTS-joined search query

fix(datagrid): guard commitCellEdit against re-entry from reload-driven resignFirstResponder

fix(datagrid): dispatch rowsInserted delta from loadMoreRows and read offset inside mutation

fix(datagrid): dispatch fullReplace delta from fetchAllRows

fix(datagrid): dispatch cellChanged delta from updateCellInTab

fix(datagrid): remove TableRows entry on individual tab close

refactor(datagrid): rebuildColumnMetadataCache reads live TableRows

style(datagrid): drop doc comments per no-comments rule

fix(datagrid): sync ResultSet snapshot with store on every mutation

fix(datagrid): unwrap optional result from addNewRow/duplicateRow

fix(datagrid): clear modified cell highlight on undo, keep FK metadata across reloads

perf(datagrid): stop syncing ResultSet snapshot on every mutation

Commits on Apr 29, 2026

test(datagrid): fix EvictionTests — selected tab is intentionally not evicted

perf(datagrid): updateCache reads live tableRowsProvider so post-Delta count is fresh

refactor(datagrid): replace editingCell binding with direct beginEditing call

chore: drop DATAGRID_REFACTOR.md handoff doc

fix(datagrid): clear cell display cache when row data is replaced

refactor(datagrid): rename RowDeltaApplying to TableViewCoordinating, add dispatch regression tests