Skip to content

Feat/support more pg types v2#111

Merged
debba merged 20 commits intoTabularisDB:mainfrom
dev-void-7:feat/support-more-pg-types-v2
Mar 31, 2026
Merged

Feat/support more pg types v2#111
debba merged 20 commits intoTabularisDB:mainfrom
dev-void-7:feat/support-more-pg-types-v2

Conversation

@dev-void-7
Copy link
Copy Markdown
Contributor

@dev-void-7 dev-void-7 commented Mar 29, 2026

What is new?

  • add support for more postgres types.
  • fix some bugs
  • add tests for Row extraction
  • make the code more consistent (function names and return type)
  • handling errors more effectively

New Supported Types:

  • Enum
  • Range
  • Multi-Range

Some Fixed Bugs:

  • the zero-dimensional array was returning as JsonValue::Null when it should be an empty array.
  • add a buffer length check to the split_at_value_len function.

Add tests to the Row extraction for:

  • Simple
  • Enum
  • Array
  • Range
  • Multi-Range
  • Composite

My Regards

Comment thread src-tauri/src/drivers/postgres/extract/range.rs Outdated
Comment thread src-tauri/src/drivers/postgres/extract/multi_range.rs
Comment thread src-tauri/src/drivers/postgres/extract/multi_range.rs
Comment thread src-tauri/src/drivers/postgres/extract/array.rs Outdated
Comment thread src-tauri/src/drivers/postgres/extract/composite.rs Outdated
@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented Mar 29, 2026

Code Review Summary

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 2
Issue Details (click to expand)

SUGGESTION

File Line Issue
src-tauri/src/drivers/postgres/extract/multi_range.rs 31 Redundant pattern binding r @ _. Use _ instead
src-tauri/src/drivers/postgres/extract/multi_range.rs 48 Redundant pattern binding r @ _. Use _ instead
Resolved Issues (fixed in new commits)
File Line Issue Status
src-tauri/src/drivers/postgres/extract/range.rs 63 Type mismatch - CRITICAL compilation error ✅ Fixed
src-tauri/src/drivers/postgres/extract/array.rs 133 Logic error in fill_nulls calculation ✅ Fixed
src-tauri/src/drivers/postgres/extract/composite.rs 50 Typo in comment - "reset" should be "rest" ✅ Fixed
Files Reviewed (9 files)
  • src-tauri/src/drivers/postgres/extract/array.rs - 0 issues (previously 1, now fixed)
  • src-tauri/src/drivers/postgres/extract/common.rs - OK
  • src-tauri/src/drivers/postgres/extract/composite.rs - 0 issues (previously 1, now fixed)
  • src-tauri/src/drivers/postgres/extract/enum.rs - OK
  • src-tauri/src/drivers/postgres/extract/mod.rs - OK
  • src-tauri/src/drivers/postgres/extract/multi_range.rs - 2 issues (unchanged)
  • src-tauri/src/drivers/postgres/extract/range.rs - 0 issues (previously 1 CRITICAL, now fixed)
  • src-tauri/src/drivers/postgres/extract/simple.rs - OK
  • src-tauri/src/drivers/postgres/mod.rs - OK

Fix these issues in Kilo Cloud


Reviewed by kimi-k2.5-0127 · 119,519 tokens

@debba debba self-assigned this Mar 31, 2026
@debba debba merged commit 052956b into TabularisDB:main Mar 31, 2026
2 checks passed
@dev-void-7 dev-void-7 deleted the feat/support-more-pg-types-v2 branch March 31, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants