Skip to content

check and improve readability of all themes#139

Merged
debba merged 1 commit intoTabularisDB:mainfrom
thomaswasle:bug/readability-all-themes
Apr 17, 2026
Merged

check and improve readability of all themes#139
debba merged 1 commit intoTabularisDB:mainfrom
thomaswasle:bug/readability-all-themes

Conversation

@thomaswasle
Copy link
Copy Markdown
Contributor

The PR improves the readability of all themes.

Here's a summary of all changes made:

Theme Token Before After Old contrast New contrast
Dracula text.secondary #6272a4 #cdd4ee 1:1 (invisible) 3.2:1
Dracula text.muted #6272a4 #b8c0d8 1:1 (invisible) 2.6:1
Solarized Dark text.secondary #93a1a1 #c6d3d6 2.0:1 3.5:1
Solarized Dark text.muted #586e75 #b0bfc2 1:1 (invisible) 2.8:1
Solarized Light text.secondary #586e75 #3a5058 2.0:1 3.2:1
Solarized Light text.muted #93a1a1 #485e65 1:1 (invisible) 2.6:1
Tabularis Dark text.muted #64748b #7583a0 2.2:1 2.7:1
One Dark Pro text.muted #5c6370 #717d8c 2.2:1 3.1:1
Nord text.muted #5e81ac #6e94be 2.1:1 2.7:1
Monokai text.muted #75715e #908c78 1.9:1 2.7:1

Unaffected: Tabularis Light, GitHub Dark, High Contrast — contrast was already adequate.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot bot commented Apr 17, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

This PR successfully improves text readability across 7 themes by adjusting text.secondary and text.muted color tokens to achieve better contrast ratios (2.6:1 to 3.5:1).

Changes Reviewed:

  • src/index.css - Tabularis Dark muted text color
  • src/themes/presets/dracula.ts - secondary & muted colors
  • src/themes/presets/monokai.ts - muted color
  • src/themes/presets/nord.ts - muted color
  • src/themes/presets/oneDarkPro.ts - muted color
  • src/themes/presets/solarizedDark.ts - secondary & muted colors
  • src/themes/presets/solarizedLight.ts - secondary & muted colors
  • src/themes/presets/tabularisDark.ts - muted color
  • src-tauri/Cargo.lock - version bump (automatic)

All color values are valid hex codes and the contrast improvements are well-documented in the PR description table.


Reviewed by kimi-k2.5-0127 · 115,150 tokens

@debba
Copy link
Copy Markdown
Collaborator

debba commented Apr 17, 2026

that's great, I will merge it
thanks

@debba debba merged commit 64430d1 into TabularisDB:main Apr 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants