Skip to content

Fix table list refresh after creating tables#239

Merged
debba merged 1 commit into
mainfrom
fix/238-create-table-refresh
May 21, 2026
Merged

Fix table list refresh after creating tables#239
debba merged 1 commit into
mainfrom
fix/238-create-table-refresh

Conversation

@debba
Copy link
Copy Markdown
Collaborator

@debba debba commented May 21, 2026

Summary

  • Refresh the table list that owns the create action, including schema and multi-database sidebar sections.
  • Pass the selected schema/database into create-table SQL preview and execution.
  • Add unit coverage for create-table target resolution.

Testing

  • pnpm typecheck
  • pnpm lint
  • pnpm exec vitest run tests/utils/createTable.test.ts

Closes #238

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented May 21, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • src/components/layout/ExplorerSidebar.tsx — Refactored to pass create-table target context (schema/database/connection) and refresh the correct scope after table creation
  • src/components/modals/CreateTableModal.tsx — Added schema prop to route table creation through the correct schema/database
  • src/utils/createTable.ts — New utility module with clean type definitions for target resolution and refresh planning
  • tests/utils/createTable.test.ts — Well-structured unit tests covering all target kinds and schema resolution edge cases

Reviewed by kimi-k2.6-20260420 · 1,350,191 tokens

@saurabh500
Copy link
Copy Markdown
Contributor

Thanks for doing this. It was a bit confusing today to not find tables, after creating them in SQL server :)

@debba
Copy link
Copy Markdown
Collaborator Author

debba commented May 21, 2026

@saurabh500 yeah I did it after testing your PR #237 :)

@debba debba merged commit 63ebeaf into main May 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Table list is not reloaded after creating a table

2 participants