feat(editor): show success feedback for non-SELECT statements#391
Merged
debba merged 4 commits intoJun 29, 2026
Conversation
Statements that return no result set (INSERT/UPDATE/DELETE and DDL such as CREATE/ALTER/DROP VIEW) previously rendered an empty grid under a misleading "0 rows retrieved" header, leaving users unsure whether the statement actually ran. Render an explicit success panel with a check icon, a "Query executed successfully" message, the affected-row count when greater than zero, and the execution time. SELECT results are unaffected. Adds the editor.queryExecuted and editor.rowsAffected i18n keys across all 8 locales.
The success panel added in the previous commit only covered the multi-result path (MultiResultPanel -> ResultEntryContent). A single statement runs through runQuery and renders the inline result block in Editor.tsx, which still showed an empty grid under "0 rows retrieved". Add the same success panel to the inline path: when the result has no columns (and there are no pending insertions), render the check icon, "Query executed successfully", the affected-row count when > 0, and the execution time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a statement returns no result set (INSERT/UPDATE/DELETE and DDL such as CREATE/ALTER/DROP VIEW), the editor now shows an explicit success panel instead of an empty grid under a misleading "0 rows retrieved" header.
Why
Running a non-SELECT statement gave no clear confirmation it succeeded — the result area showed "0 rows retrieved" and an empty grid, leaving users unsure whether anything happened.
How
A non-SELECT result has
columns.length === 0. Both result-rendering paths now detect that and render a success panel (check icon, "Query executed successfully", the affected-row count when greater than zero, and the execution time):Editor.tsx(viarunQuery).ResultEntryContent(used byMultiResultPanelandStackedResultItem).SELECT results are unaffected; a SELECT returning zero rows still shows its grid and header. The affected-row line is hidden when the count is zero, so DDL reads cleanly as just "Query executed successfully".
Adds the
editor.queryExecutedandeditor.rowsAffectedi18n keys across all 8 locales.Testing
pnpm typecheckand ESLint pass.INSERT,UPDATEandCREATE OR REPLACE VIEWnow shows the success panel (with the affected-row count for DML, and without it for DDL).