Add Phase 3 network foundation slices#17
Merged
TacoRocket merged 2 commits intomainfrom Apr 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
nics,endpoints, andnetwork-portsslices as one network foundation branchnetwork-effectivefuture candidate for deeper Azure effective-ingress analysisWhy it changed
nicsestablishes attachment and network-boundary evidenceendpointssurfaces reachable IP and hostname entry pointsnetwork-portsadds likely inbound allow evidence from visible NIC and subnet NSGs without over-claiming full effective reachabilityImplementation notes
network-portsnow avoids falsely claiming no NSG visibility when a subnet NSG is visible but has no matching allow rulesresource_group/nameto avoid ambiguity when names repeat across groupsValidation
python3 -m pytest tests/test_collectors.py tests/test_golden_outputs.py tests/test_contract_schemas.py tests/test_cli_smoke.py tests/test_help.py tests/test_terminal_ux.py tests/test_models.py83 passed, 2 deselected)Notes
src/azurefox/correlation/findings.pywas applied only to satisfy the repo push guardrail on the mixed worktree