fix: harden trust edge truthfulness#26
Merged
TacoRocket merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This fixes several review findings across the completed Phase 1 through Phase 3 surfaces.
auth-policiesso unreadable Conditional Access does not imply missing enforcementrole-truststo enumerate readable Graph trust edges directly instead of only seeded principal-bound itemsworkloadsand related help wording stop implying Azure-managed hostnames are automatically reachablerole-trustsscale modesWhy It Changed
The clean-context review pass found several cases where AzureFox could overstate what it truly knew from the current evidence path, plus one
role-trustsscope gap where the implementation was narrower than the documented trust-edge boundary.This change set brings the shipped behavior back in line with the roadmap's trustworthiness and partial-read expectations.
Impact
auth-policiesfindings are now more truthful under partial Graph visibilityrole-trustsis broader and closer to the intended Phase 1 trust-edge scopeValidation
python3 -m ruff check src tests scriptsPYTHONPATH=src python3 scripts/generate_schemas.pyPYTHONPATH=src python3 -m pytest133 passed, 2 deselectedFollow-On
Recommend updating the sister repo now, before new Phase 3 follow-on depth lands, so it can catch up to the corrected evidence boundaries and wording at a stable checkpoint.