Skip to content

Update version to 0.6.0#400

Merged
KenVanHoeylandt merged 2 commits intomainfrom
prepare-for-release
Oct 29, 2025
Merged

Update version to 0.6.0#400
KenVanHoeylandt merged 2 commits intomainfrom
prepare-for-release

Conversation

@KenVanHoeylandt
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 28, 2025

📝 Walkthrough

Walkthrough

Updated release metadata and configuration plus documentation edits. version.txt: changed 0.6.0-dev to 0.6.0. Boards/waveshare-s3-touch-lcd-43/Source/Configuration.cpp: removed the uiScale member assignment from the exported hardwareConfiguration initializer. Documentation/ideas.md: replaced a TODO about the Ili934x driver with multiple release-focused items and added a Diceware UI note. Documentation/releasing.md: rewrote the release checklist into a multi-step publishing flow covering versioning, SDK/CDN uploads, TactilityApps/TactilityWebInstaller publishing, and final validation.

Pre-merge checks

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ❓ Inconclusive No pull request description was provided by the author. While the check is explicitly lenient and requires only that the description not be completely off-topic, an absent description cannot be evaluated as related to the changeset. However, since the description is not present rather than being off-topic, it does not meet the criteria for a clear failure. Consider adding a pull request description that explains the purpose and scope of these changes. Even a brief description would help reviewers understand that this PR encompasses version updates, configuration adjustments, and documentation updates for the release process, providing better context for the changeset.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Update version to 0.6.0" directly relates to one of the actual changes in the changeset: the version.txt file was updated from 0.6.0-dev to 0.6.0. The title is clear, specific, and concise without vague language or misleading content. While the PR also includes other changes (configuration modification, documentation updates), the title successfully identifies and communicates a significant and real aspect of this release-preparation changeset.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6afe5a2 and 1c6bd52.

📒 Files selected for processing (3)
  • Boards/waveshare-s3-touch-lcd-43/Source/Configuration.cpp (0 hunks)
  • Documentation/ideas.md (2 hunks)
  • Documentation/releasing.md (1 hunks)
💤 Files with no reviewable changes (1)
  • Boards/waveshare-s3-touch-lcd-43/Source/Configuration.cpp
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-28T05:42:03.372Z
Learnt from: NellowTCS
PR: ByteWelder/Tactility#398
File: Boards/LilygoTdisplayS3/Source/devices/Display.cpp:183-199
Timestamp: 2025-10-28T05:42:03.372Z
Learning: The LilyGo T-Display S3 board (Boards/LilygoTdisplayS3) requires a non-standard LVGL flush pattern in its ST7789 i8080 display driver. In st7789_send_color_cb, lv_display_flush_ready() must be called immediately after esp_lcd_panel_io_tx_color() with a vTaskDelay(1), rather than using standard DMA completion callbacks via esp_lcd_panel_io_register_event_callbacks. Standard DMA callback approaches cause display corruption on this specific board. This pattern was tested against multiple alternatives (callback registration, buffer tuning, clock reduction) and is the only stable solution for T-Display S3 hardware.

Applied to files:

  • Documentation/ideas.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: build (waveshare-s3-touch-lcd-128, esp32s3)
  • GitHub Check: build (m5stack-cardputer, esp32s3)
  • GitHub Check: build (m5stack-stickc-plus, esp32)
  • GitHub Check: build (lilygo-tdongle-s3, esp32s3)
  • GitHub Check: build (elecrow-crowpanel-basic-35, esp32)
  • GitHub Check: build (lilygo-tdeck, esp32s3)
  • GitHub Check: build (cyd-2432s028rv3, esp32)
  • GitHub Check: build (elecrow-crowpanel-advance-50, esp32s3)
  • GitHub Check: build (cyd-e32r28t, esp32)
  • GitHub Check: build (cyd-4848s040c, esp32s3)
  • GitHub Check: build (cyd-jc2432w328c, esp32)
  • GitHub Check: build (cyd-8048s043c, esp32s3)
  • GitHub Check: build (cyd-e32r32p, esp32)
  • GitHub Check: build (cyd-2432s028r, esp32)
  • GitHub Check: build (elecrow-crowpanel-basic-28, esp32)
  • GitHub Check: build (cyd-2432s032c, esp32)
  • GitHub Check: build (cyd-2432s024c, esp32)
  • GitHub Check: Linux
  • GitHub Check: macOS
  • GitHub Check: run
🔇 Additional comments (2)
Documentation/ideas.md (1)

5-8: Targeted release prep items replace vague driver TODO.

Replacing the abstract "convert Ili934x driver" with concrete, release-blocking issues (memory constraints, App Hub stability, install glitches) provides clearer visibility into blockers for the 0.6.0 release.

Documentation/releasing.md (1)

3-26: Well-structured, explicit multi-step release workflow.

The rewrite transforms a flat checklist into a logically sequenced workflow with clear artifact handoffs: Tactility repo → CDN (SDK) → TactilityApps → TactilityWebInstaller → Documentation → GitHub Release. Explicit steps for CDN uploads, sdk.json updates, and validation reduce ambiguity and improve repeatability.

The added focus on testing (step 5) aligns with the release-blocking items noted in ideas.md (App Hub, Wi-Fi).

Please verify that the new multi-step process aligns with the actual CI/CD infrastructure and that all referenced tools/scripts (e.g., release-all.py, TactilityTool CDN updates) exist and remain current.

Comment thread Documentation/ideas.md
@KenVanHoeylandt KenVanHoeylandt merged commit 4a343e5 into main Oct 29, 2025
36 checks passed
@KenVanHoeylandt KenVanHoeylandt deleted the prepare-for-release branch October 29, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant