Skip to content

Styling fixes for paper displays#514

Merged
KenVanHoeylandt merged 2 commits intoTactilityProject:mainfrom
Shadowtrance:paper-theme-style
Mar 14, 2026
Merged

Styling fixes for paper displays#514
KenVanHoeylandt merged 2 commits intoTactilityProject:mainfrom
Shadowtrance:paper-theme-style

Conversation

@Shadowtrance
Copy link
Contributor

@Shadowtrance Shadowtrance commented Mar 14, 2026

Styling fixes for paper displays and a bonus symbol because it is needed for the epub reader app. :)

There's probably more to do be done but that's basically everything i can see running on the paper s3 and a few extra's i can't but are obvious (like the gps and other dropdowns).

Overall i think paper displays could do with a slightly heavier font weight but that's really down to the default lvgl font kinda sucking on paper displays. but it works i guess.

Summary by CodeRabbit

  • New Features

    • Improved font/text rendering support for certain displays.
  • Style

    • Removed borders from many dropdowns for a cleaner look.
    • Added display-format-aware color adjustments to maintain consistent visuals on 8-bit and other displays.
    • Enhanced conditional theming for switches, spinners, text areas, and other UI elements to better match device capabilities.

styling fixes for paper displays
@coderabbitai
Copy link

coderabbitai bot commented Mar 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b554f1bb-ad8d-4f73-af02-d3dce3fd6e5d

📥 Commits

Reviewing files that changed from the base of the PR and between 9d75828 and 27d6172.

📒 Files selected for processing (1)
  • Tactility/Source/lvgl/Toolbar.cpp
🚧 Files skipped from review as they are similar to previous changes (1)
  • Tactility/Source/lvgl/Toolbar.cpp

📝 Walkthrough

Walkthrough

A new LVGL module symbol lv_style_set_text_font was added to the module symbol list. Many app-level files had explicit border styling removed from dropdowns (GPS, display, keyboard, notes, screenshot, trackball, i2c scanner, etc.). Several UI components now apply colors conditionally when the display color format is LV_COLOR_FORMAT_L8 (chat, development, notes, web server, toolbar spinner). LVGL wrapper code was changed to apply format-aware styling for dropdowns, switches, and textareas. A hard-coded font assignment in web server settings was removed.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Styling fixes for paper displays' directly corresponds to the main changes in the PR, which involve conditional styling adjustments based on the LV_COLOR_FORMAT_L8 display format used on paper displays, along with dropdown border removals and other styling refinements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Tactility/Source/lvgl/Toolbar.cpp (1)

231-233: Avoid duplicate L8 switch bg-color styling in toolbar.

Line 231-233 duplicates behavior already added in Tactility/Source/lvgl/wrappers/switch.cpp (__wrap_lv_switch_create). Keeping it in one place reduces drift risk.

♻️ Proposed cleanup
-    if (lv_display_get_color_format(lv_obj_get_display(obj)) == LV_COLOR_FORMAT_L8) {
-        lv_obj_set_style_bg_color(widget, lv_theme_get_color_secondary(obj), LV_PART_MAIN);
-    }

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2433903e-aee6-4313-b5f7-b58ba7592093

📥 Commits

Reviewing files that changed from the base of the PR and between aa7530e and 9d75828.

📒 Files selected for processing (15)
  • Modules/lvgl-module/source/symbols.c
  • Tactility/Source/app/addgps/AddGps.cpp
  • Tactility/Source/app/chat/ChatView.cpp
  • Tactility/Source/app/development/Development.cpp
  • Tactility/Source/app/display/Display.cpp
  • Tactility/Source/app/i2cscanner/I2cScanner.cpp
  • Tactility/Source/app/keyboard/KeyboardSettings.cpp
  • Tactility/Source/app/notes/Notes.cpp
  • Tactility/Source/app/screenshot/Screenshot.cpp
  • Tactility/Source/app/trackball/TrackballSettings.cpp
  • Tactility/Source/app/webserversettings/WebServerSettings.cpp
  • Tactility/Source/lvgl/Toolbar.cpp
  • Tactility/Source/lvgl/wrappers/dropdown.cpp
  • Tactility/Source/lvgl/wrappers/switch.cpp
  • Tactility/Source/lvgl/wrappers/textarea.cpp
💤 Files with no reviewable changes (6)
  • Tactility/Source/app/keyboard/KeyboardSettings.cpp
  • Tactility/Source/app/addgps/AddGps.cpp
  • Tactility/Source/app/trackball/TrackballSettings.cpp
  • Tactility/Source/app/screenshot/Screenshot.cpp
  • Tactility/Source/app/display/Display.cpp
  • Tactility/Source/app/i2cscanner/I2cScanner.cpp

@KenVanHoeylandt
Copy link
Contributor

Good stuff, thank you!

@KenVanHoeylandt KenVanHoeylandt merged commit e560cc7 into TactilityProject:main Mar 14, 2026
54 checks passed
@Shadowtrance Shadowtrance deleted the paper-theme-style branch March 14, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants