Styling fixes for paper displays#514
Conversation
styling fixes for paper displays
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughA new LVGL module symbol 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can suggest fixes for GitHub Check annotations.Configure the |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Tactility/Source/lvgl/Toolbar.cpp (1)
231-233: Avoid duplicate L8 switch bg-color styling in toolbar.Line 231-233 duplicates behavior already added in
Tactility/Source/lvgl/wrappers/switch.cpp(__wrap_lv_switch_create). Keeping it in one place reduces drift risk.♻️ Proposed cleanup
- if (lv_display_get_color_format(lv_obj_get_display(obj)) == LV_COLOR_FORMAT_L8) { - lv_obj_set_style_bg_color(widget, lv_theme_get_color_secondary(obj), LV_PART_MAIN); - }
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2433903e-aee6-4313-b5f7-b58ba7592093
📒 Files selected for processing (15)
Modules/lvgl-module/source/symbols.cTactility/Source/app/addgps/AddGps.cppTactility/Source/app/chat/ChatView.cppTactility/Source/app/development/Development.cppTactility/Source/app/display/Display.cppTactility/Source/app/i2cscanner/I2cScanner.cppTactility/Source/app/keyboard/KeyboardSettings.cppTactility/Source/app/notes/Notes.cppTactility/Source/app/screenshot/Screenshot.cppTactility/Source/app/trackball/TrackballSettings.cppTactility/Source/app/webserversettings/WebServerSettings.cppTactility/Source/lvgl/Toolbar.cppTactility/Source/lvgl/wrappers/dropdown.cppTactility/Source/lvgl/wrappers/switch.cppTactility/Source/lvgl/wrappers/textarea.cpp
💤 Files with no reviewable changes (6)
- Tactility/Source/app/keyboard/KeyboardSettings.cpp
- Tactility/Source/app/addgps/AddGps.cpp
- Tactility/Source/app/trackball/TrackballSettings.cpp
- Tactility/Source/app/screenshot/Screenshot.cpp
- Tactility/Source/app/display/Display.cpp
- Tactility/Source/app/i2cscanner/I2cScanner.cpp
|
Good stuff, thank you! |
Styling fixes for paper displays and a bonus symbol because it is needed for the epub reader app. :)
There's probably more to do be done but that's basically everything i can see running on the paper s3 and a few extra's i can't but are obvious (like the gps and other dropdowns).
Overall i think paper displays could do with a slightly heavier font weight but that's really down to the default lvgl font kinda sucking on paper displays. but it works i guess.
Summary by CodeRabbit
New Features
Style