Skip to content

fix: remove invalid child_id relationships from tag_parents#1423

Merged
CyanVoxel merged 3 commits into
mainfrom
fix-1419
Jul 4, 2026
Merged

fix: remove invalid child_id relationships from tag_parents#1423
CyanVoxel merged 3 commits into
mainfrom
fix-1419

Conversation

@CyanVoxel

@CyanVoxel CyanVoxel commented Jul 4, 2026

Copy link
Copy Markdown
Member

Summary

This PR applies a migration patch similar to 102 that fixes existing library data where a child tag that is referenced in a tag_parents relationship has been deleted but the relationship has remained in the database. This should be enough to fix #1419. Bumps the DB version to 202.

Since the parent_id side of deleting tag_parent relationships was corrected in #1107, it shouldn't be necessary to correct for invalid data in this direction as migration 102 did. Meanwhile #1250 ensures that no invalid data like this should be left behind going forward.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added this to the Alpha v9.6.1 milestone Jul 4, 2026
@CyanVoxel CyanVoxel added Priority: Critical An issue that requires immediate attention TagStudio: Library Relating to the TagStudio library system TagStudio: Tags Relating to the TagStudio tag system Status: Review Needed A review of this is needed Type: Fix A fix for a bug, typo, or other issue labels Jul 4, 2026
@CyanVoxel CyanVoxel moved this to 🏓 Ready for Review in TagStudio Development Jul 4, 2026
Comment thread src/tagstudio/core/library/alchemy/library.py Outdated
@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Jul 4, 2026
@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 👀 In review in TagStudio Development Jul 4, 2026
@CyanVoxel CyanVoxel moved this from 👀 In review to 🍃 Pending Merge in TagStudio Development Jul 4, 2026
@CyanVoxel CyanVoxel merged commit 95e2fe7 into main Jul 4, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development Jul 4, 2026
@CyanVoxel CyanVoxel deleted the fix-1419 branch July 4, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Critical An issue that requires immediate attention TagStudio: Library Relating to the TagStudio library system TagStudio: Tags Relating to the TagStudio tag system Type: Fix A fix for a bug, typo, or other issue

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Tag parent relationship can remain after child is deleted

2 participants