fix/refactor: use generic ModuleStatus class for getting status of optional modules#1427
Merged
Conversation
Member
Author
|
@Computerdores Implemented feedback and added a small new addition where tooltips show the module locations on the "About" screen |
Computerdores
approved these changes
Jul 5, 2026
Computerdores
left a comment
Collaborator
There was a problem hiding this comment.
Looking good besides two nits.
The new about window looks really good btw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new generic ModuleStatus class to get the locations and versions of FFmpeg, FFprobe, ripgrep, and any other future optional modules. I've also updated the "About" screen with the ripgrep version, and put these optional modules under their own section to better indicate that they're technically optional. Fixes #1405.
Tasks Completed