Skip to content

fix/refactor: use generic ModuleStatus class for getting status of optional modules#1427

Merged
CyanVoxel merged 7 commits into
mainfrom
module-search
Jul 5, 2026
Merged

fix/refactor: use generic ModuleStatus class for getting status of optional modules#1427
CyanVoxel merged 7 commits into
mainfrom
module-search

Conversation

@CyanVoxel

Copy link
Copy Markdown
Member

Summary

This PR introduces a new generic ModuleStatus class to get the locations and versions of FFmpeg, FFprobe, ripgrep, and any other future optional modules. I've also updated the "About" screen with the ripgrep version, and put these optional modules under their own section to better indicate that they're technically optional. Fixes #1405.

image

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added this to the Alpha v9.6.1 milestone Jul 4, 2026
@CyanVoxel CyanVoxel added Type: Refactor Code that needs to be restructured or cleaned up Type: Installation Installing, building, and/or launching the program Type: UI/UX User interface and/or user experience labels Jul 4, 2026
@CyanVoxel CyanVoxel added Priority: High An important issue requiring attention Status: Review Needed A review of this is needed Type: Fix A fix for a bug, typo, or other issue labels Jul 4, 2026
@CyanVoxel CyanVoxel marked this pull request as draft July 4, 2026 23:18
@CyanVoxel CyanVoxel moved this to 🏓 Ready for Review in TagStudio Development Jul 4, 2026
@CyanVoxel CyanVoxel marked this pull request as ready for review July 4, 2026 23:41
Comment thread src/tagstudio/core/utils/ffmpeg_status.py Outdated
Comment thread src/tagstudio/resources/translations/en.json
Comment thread src/tagstudio/qt/ts_qt.py Outdated
Comment thread src/tagstudio/qt/previews/vendored/probe.py
Comment thread src/tagstudio/core/utils/ffmpeg_status.py Outdated
@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 👀 In review in TagStudio Development Jul 5, 2026
@CyanVoxel

Copy link
Copy Markdown
Member Author

@Computerdores Implemented feedback and added a small new addition where tooltips show the module locations on the "About" screen

@Computerdores Computerdores left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good besides two nits.
The new about window looks really good btw

Comment thread src/tagstudio/core/utils/ffmpeg_status.py
Comment thread src/tagstudio/core/utils/module_status.py
@CyanVoxel CyanVoxel merged commit 23ef996 into main Jul 5, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in TagStudio Development Jul 5, 2026
@CyanVoxel CyanVoxel deleted the module-search branch July 5, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: High An important issue requiring attention Status: Review Needed A review of this is needed Type: Fix A fix for a bug, typo, or other issue Type: Installation Installing, building, and/or launching the program Type: Refactor Code that needs to be restructured or cleaned up Type: UI/UX User interface and/or user experience

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[Bug]: ripgrep inaccessible in macOS builds

2 participants