Small fix: Remove unnecessary warning in console #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Bug
CyanVoxel
reviewed
Nov 29, 2024
Member
CyanVoxel
left a comment
CyanVoxel
left a comment
There was a problem hiding this comment.
Looks pretty good! The only suggestion I have is that inside QPushButtonWrapper, self.remove_button.is_connected is still set to False by default despite it no longer being used as a boolean value. If this value is now dependent on it containing a callable or not, I would suggest changing this line to self.is_connected: callable | None = None
Collaborator
Author
|
Hi, callable is an inbuilt function that should return True if it's a callable that's passed in and otherwise returns false from what I know. So it should still be a boolean i think. |
yedpodtrzitko
pushed a commit
to yedpodtrzitko/TagStudio
that referenced
this pull request
Dec 2, 2024
* fix: cannot disconnect from None Warning * fix: cannot disconnect from None Warning mypy compliant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I removed the Warning that is shown in the console that occurs when Tagstudio is opened and a thumbnail is clicked for the first time.
Bug:
Fix:
Check if provided callback function is actually a Callable and preventing it from trying to disconnect when the callback is None.