Draft spec 0007: .NET Framework 4.8 port#197
Merged
Merged
Conversation
Supersedes spec 0006 (self-contained tournament build, ruled out by the spike on #190). The port replaces the net6.0-windows target with net48 across all three projects so the packed XLL produced by ExcelDNA becomes a true single-file artifact with no runtime prerequisite — serving both the regular installer and the tournament zip.
Tim's calls: - Inline Taglo.Excel.Common rather than multi-target (revisit later if a second consumer appears) - Pin gong-wpf-dragdrop and Ookii.Dialogs.Wpf to net48-compatible versions - Deprecate the InnoSetup installer entirely — single zip distribution Reworked the proposed solution accordingly: distribution collapses to a single LambdaBoss-x.y.z.zip (XLL + README + unblock.cmd); installer deletion is now in scope; new scripts/build-release-bundle.ps1 replaces the InnoSetup compile step in publish-release.ps1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three downstream decisions folded in after first review:
LambdaBoss-x.y.z.zip(signed packed XLL + README +unblock.cmd).Taglo.Excel.Commoninlined rather than multi-targeted across repos. Revisit splitting if a second consumer appears.gong-wpf-dragdropandOokii.Dialogs.Wpfpinned to net48-compatible versions rather than replaced.Marked draft for spec review. Once approved, implementation plan + issues will follow.
Test plan