Airsonic cover art breaks upon view switch(F5)

[C0rn3j]

tested against current master on Windows, loads fine initially but can't handle any switching:

2025-02-28 16:09:56 [ ERROR ] [  t_main  ] Image load error (t_main.py:8254)
Traceback (most recent call last):
  File "C:/msys64/home/Yeet/Tauon/src/tauon/t_modules/t_main.py", line 7996, in display
    im = Image.open(source_image)
         ^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:/msys64/mingw64/lib/python3.12/site-packages/PIL/Image.py", line 3471, in open
    fp.seek(0)
ValueError: I/O operation on closed file.
2025-02-28 16:09:56 [ ERROR ] [  t_main  ] -- Associated track: -/EXIT TUNES PRESENTS GUMish/05 - キッチンでカッパがタニシ茹でてる.mp3 (t_main.py:8255)

[Taiko2k]

This is likely to do with the variable self.downloaded_image of the AlbumArt object.

When an image is downloaded, it is assigned to self.downloaded_image. The display() member then renders the art, and now cleans up using source_image.close(), but this will also close self.downloaded_image since it is the same object. Subsequent requests to display will then fail when it tries to use cached self.downloaded_image

The easiest solution would be to self.downloaded_image = None when calling source_image.close(), but this could increase network re-downloads as there is no other caching mechanism for this function. Ok there is but it only applies when the requested image size is the same, if its different it need access to the source image to generate another high quality thumbnail, which is why the error presents on view change.

There is also maybe the issue of network inhibition in case of error. If self.downloaded_image is wiped, it might keep requesting downloads on error.

[Taiko2k]

Possible fix committed, (just not close the object if its a networked track)